[ 
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055333#comment-15055333
 ] 

ASF GitHub Bot commented on TAJO-1999:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/891#discussion_r47457648
  
    --- Diff: 
tajo-storage/tajo-storage-hdfs/src/test/java/org/apache/tajo/storage/TestMergeScanner.java
 ---
    @@ -165,7 +167,9 @@ public void testMultipleFiles() throws IOException {
         targetSchema.addColumn(schema.getColumn(0));
         targetSchema.addColumn(schema.getColumn(2));
     
    -    Scanner scanner = new MergeScanner(conf, schema, meta, 
TUtil.newList(fragment), targetSchema);
    +    List inputList = new ArrayList<>();
    +    inputList.addAll(Arrays.asList(fragment));
    +    Scanner scanner = new MergeScanner(conf, schema, meta, inputList, 
targetSchema);
    --- End diff --
    
    Can be rewritten with Arrays.asList().


> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
>                 Key: TAJO-1999
>                 URL: https://issues.apache.org/jira/browse/TAJO-1999
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility 
> methods anymore. We need to eliminate them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to