[ 
https://issues.apache.org/jira/browse/TAJO-1999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15055331#comment-15055331
 ] 

ASF GitHub Bot commented on TAJO-1999:
--------------------------------------

Github user jihoonson commented on a diff in the pull request:

    https://github.com/apache/tajo/pull/891#discussion_r47457639
  
    --- Diff: 
tajo-storage/tajo-storage-hbase/src/main/java/org/apache/tajo/storage/hbase/HBaseTablespace.java
 ---
    @@ -462,8 +462,10 @@ public URI getTableUri(String databaseName, String 
tableName) {
               stopRows.add(stopRow);
             }
           } else {
    -        startRows = TUtil.newList(HConstants.EMPTY_START_ROW);
    -        stopRows = TUtil.newList(HConstants.EMPTY_END_ROW);
    +        startRows = new ArrayList<>();
    +        startRows.addAll(Arrays.asList(HConstants.EMPTY_START_ROW));
    +        stopRows = new ArrayList<>();
    +        stopRows.addAll(Arrays.asList(HConstants.EMPTY_END_ROW));
    --- End diff --
    
    Can be rewritten with a single constructor call.


> TUtil.newList/newLinkedHashMap should be replaced by Java's diamond operator
> ----------------------------------------------------------------------------
>
>                 Key: TAJO-1999
>                 URL: https://issues.apache.org/jira/browse/TAJO-1999
>             Project: Tajo
>          Issue Type: Improvement
>            Reporter: Dongkyu Hwangbo
>            Assignee: Dongkyu Hwangbo
>            Priority: Minor
>              Labels: migration, newbie
>
> We introduced Java 8. We don't need TUtil.newList/newLinkedHashMap utility 
> methods anymore. We need to eliminate them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to