ivtv wrote:
This fixes the two instances of segfaults recently reported, number
one was a problem when doing fast firmware load, we didn't check the
return value of the i2c write which we now do and disable fast
firmware load if it fails, and if it still fails then bail out of fw
loading completely to keep from an oops occuring.
Oh derr, yeah good point on that. Didn't even think about the fact
that the i2c_master_send would return an error.
However, -ENOSYS is only returned if there is no master_xfer
function defined for the i2c client. If this happens, there would be no
need to retry, because that's not something that would change. If the
transfer itself failed, it should be -ETIMEDOUT. Probably best to
change it to just a < 0 check to cover any error case (-EFAULT could
also be returned).
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r=20
_______________________________________________
ivtv-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/ivtv-devel
