That comment is indeed obsolete. It's easy to remove this and regenerate the samples. Just say the word and I will take care The point is this does not fix the issue and I am not able to do actual testing on this code. I also do not understand why this sample seems to pass buildbot if there is a missing procedure...
Joep 2011/8/19 Piers Goodhew <[email protected]>: > OK, if you make the "G" addition to glcd_ks0108.jal, the following code, > adapted from the not-working-for-me 16f877a_glcd_ks0108.jal, works. > Further: > > removing the "g" from glcd_write_char (in glcd_ks0108) results in big white > blocks, not chars (some bug further up in the pbp routine?) > Not having the extra 2 font includes > (include glcd_5x7_font include glcd_font ) and the glcd_font_use() will > result in no text of any kind (with or without the "g fix") > the very first comment isn't right. No game of life here! > > -- Title: Test program shows Conway's 'game of life' on a ks0108 graphic LCD > > -- Author: Joep Suijs, Copyright (c) 2008-2011, all rights reserved. > > -- Adapted-by: > > -- Compiler: >=2.4m > > -- Revision: $Revision: 2760 $ > > -- > > -- This file is part of jallib (http://jallib.googlecode.com) > > -- Released under the ZLIB license > (http://www.opensource.org/licenses/zlib-license.html) > > -- > > -- Description: > > -- http://en.wikipedia.org/wiki/Conway's_Game_of_Life > > -- > > -- > > -- This file has been generated from: > > -- * board: board_16f877a_startersguide.jal > > -- * test : test_glcd_ks0108.jal > > -- > > -- (and then ported to the 16f723a, the serial (and some other) stuff > commented out, > > -- and set up to use the int osc, by Piers Goodhew, August 2011) > > -- > > ;@jallib section chipdef > > -- chip setup > > include 16f723a > > -- configuration memory settings (fuses) > > pragma target clock 4_000_000 -- xtal frequency > > pragma target OSC INTOSC_NOCLKOUT -- internal to start with I > think > > pragma target PLLEN F16MHz -- int osc PLL enabled (higher frequencies) > > pragma target WDT disabled -- no watchdog > > pragma target DEBUG disabled -- no debugging > > pragma target MCLR external -- reset externally > > -- GRAPHIC_LCD IO definition > > var volatile byte GLCD_DATAPRT is portc > > var volatile byte GLCD_DATAPRT_DIR is portc_direction > > var volatile bit GLCD_RW is pin_a4 > > var volatile bit GLCD_CS1 is pin_a2 > > var volatile bit GLCD_E is pin_a5 > > var volatile bit GLCD_DI is pin_a3 > > var volatile bit GLCD_RST is pin_b0 > > var volatile bit GLCD_CS2 is pin_a1 > > var volatile bit GLCD_RW_DIRECTION is pin_a4_direction > > var volatile bit GLCD_CS1_DIRECTION is pin_a2_direction > > var volatile bit GLCD_E_DIRECTION is pin_a5_direction > > var volatile bit GLCD_DI_DIRECTION is pin_a3_direction > > var volatile bit GLCD_RST_DIRECTION is pin_b0_direction > > var volatile bit GLCD_CS2_DIRECTION is pin_a1_direction > > include print > > include random > > OSCCON_IRCF = 0b01 -- Clock to 4MHz (TODO: lose if we're on xtal) > > include delay > > include glcd_5x7_font > > include glcd_font > > include glcd_ks0108 > > include glcd_common > > glcd_init() > > glcd_font_use(FONT_5X7) > > const byte str1[] = "Test graph display. " -- define a string > > ;print_string(serial_hw_data, str1) -- output string > > ;glcd_box ( 0,0, 127,63) > > > > include print > > glcd_char_y_pos = 20; > > glcd_char_x_pos = 20 > > ;glcd_line(0, 0, 32, 63) > > ;glcd_line(0, 0, 64, 63) > > ;glcd_line(0, 0, 127,63) > > print_string(glcd, str1) > > glcd_box( 0,0, 127,63) > > delay_100ms(10) > > forever loop > > delay_100ms(5) > > -- fill with chars > > var byte x, y, char; > > char = 32 > > for 8 using y loop > > glcd_char_goto(0, (y+1) * _glcd_font_current_height ) > > for 25 using x loop > > glcd = char > > char = char + 1 > > if (char > 122) then char = 32 end if > > end loop > > end loop > > ;serial_hw_data = "+" > > end loop > > -- > You received this message because you are subscribed to the Google Groups > "jallib" group. > To view this discussion on the web visit > https://groups.google.com/d/msg/jallib/-/49QjHNp1sukJ. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/jallib?hl=en. > -- You received this message because you are subscribed to the Google Groups "jallib" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/jallib?hl=en.
