Am Mittwoch, 23. Oktober 2002 23:29 schrieb David Brownell:
> > hcd_data_lock is taken too late.
>
> That'll go away in the final core patch to remove automagic
> resubmit for interrupt ... which will no longer zero urb->dev.

That's good news, but where do you want to take it?
I don't see any significance to this problem.
Could you enlighten me?
If urb->zero is NULL I am happy, because we can bail out.
The problem is not NULL but a pointer to freed memory.
The correct sequence in the driver is:
down(mutex_with_disconnect);
if (privat->device_is_still_present)
        usb_submit_urb(urb);
up(mutex_with_disconnect);

You cannot push the locking farther down because neither
the lock nor the flag can reside in struct device or struct usb_device.

> I've been running that patch without seeing any problems
> attributed to it, so I suspect I'll submit it soon to Greg.

By all means.

        Regards
                Oliver



-------------------------------------------------------
This sf.net email is sponsored by: Influence the future
of Java(TM) technology. Join the Java Community
Process(SM) (JCP(SM)) program now.
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0002en

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to