onichols-pivotal commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r425331746
##########
File path:
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
/**
* Initialize the SSLParameterExtension.
*
- * @param config the DistributionConfig
+ * @param properties the Properties
*/
- default void init(DistributionConfig config) {}
+ default void init(Properties properties) {}
Review comment:
I would like to see some javadoc comments explaining both
1) why a breaking change was justified, and
2) documentation of property names and suitable values for each that need to
be in this Properties object
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
