pivotal-jbarrett commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r425895176
##########
File path:
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
/**
* Initialize the SSLParameterExtension.
*
- * @param config the DistributionConfig
+ * @param properties the Properties
*/
- default void init(DistributionConfig config) {}
+ default void init(Properties properties) {}
Review comment:
The system properties isn't really a good API though. I really think we
should make a concrete class, even if over time we have to evolve it to have
more information. It's controlled and strongly typed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
