pivotal-jbarrett commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r425344240
##########
File path:
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
/**
* Initialize the SSLParameterExtension.
*
- * @param config the DistributionConfig
+ * @param properties the Properties
*/
- default void init(DistributionConfig config) {}
+ default void init(Properties properties) {}
Review comment:
>why a breaking change was justified
Think of this change as taking something that was internal and making it
public API. The original introduction of this API was intended to be public but
included components that are internal thus making it effectively an internal
API.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
