pivotal-jbarrett commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r432033977
##########
File path:
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
/**
* Initialize the SSLParameterExtension.
*
- * @param config the DistributionConfig
+ * @param properties the Properties
*/
- default void init(DistributionConfig config) {}
+ default void init(Properties properties) {}
Review comment:
Then why change it at all for 1.13. It’s broken now. It will be broken
later if we add @experimental knowing we will change it in the next release.
Might as well save the trouble and skip this PR for 1.13 entirely and do it
right in 1.14.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
