onichols-pivotal commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r432038317
##########
File path:
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
/**
* Initialize the SSLParameterExtension.
*
- * @param config the DistributionConfig
+ * @param properties the Properties
*/
- default void init(DistributionConfig config) {}
+ default void init(Properties properties) {}
Review comment:
Using an internal class in a public API is "more broken", and we want to
address that immediately. It remains unclear what a long-term solution should
look like. Properties may be distasteful to some but seems sufficient to fix
the internal API leakage. Adding @Experimental now allows us to refine the API
in the future and hopefully deprecate the use of Properties someday.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
