pivotal-jbarrett commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r432030087
##########
File path:
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
/**
* Initialize the SSLParameterExtension.
*
- * @param config the DistributionConfig
+ * @param properties the Properties
*/
- default void init(DistributionConfig config) {}
+ default void init(Properties properties) {}
Review comment:
I’m not sure what the consensus is reading the threads. I see myself and
a +1 in favor of something more strongly defined. I see the original PR for
just properties with an approval by the same person that +1 the suggested
change. *shrug*
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
