pivotal-jbarrett commented on a change in pull request #5115:
URL: https://github.com/apache/geode/pull/5115#discussion_r425344950



##########
File path: 
geode-core/src/main/java/org/apache/geode/net/SSLParameterExtension.java
##########
@@ -29,9 +29,9 @@
   /**
    * Initialize the SSLParameterExtension.
    *
-   * @param config the DistributionConfig
+   * @param properties the Properties
    */
-  default void init(DistributionConfig config) {}
+  default void init(Properties properties) {}

Review comment:
       >documentation of property names and suitable values for each that need 
to be in this Properties object
   
   @mivanac If you can name these then I think it justifies the request I had 
to have a concrete domain object for this API rather than a wide open property 
bag.
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to