sadpandajoe commented on code in PR #45264: URL: https://github.com/apache/superset/pull/45264#discussion_r4309572985
########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -7666,14 +7719,14 @@ msgstr "ジオメトリ列" msgid "Get the last date by the date unit." msgstr "日付単位に基づいて最後の日付を取得します。" -msgid "Get the specified date for the holiday" +msgid "Get the specify date for the holiday" Review Comment: This edit changes the msgid to `Get the specify date for the holiday`, which no longer matches the source string (`Get the specified date for the holiday` in `messages.pot` and the holiday tooltip in the frontend). gettext looks translations up by exact msgid, so Japanese users will see the English text for this tooltip instead of the translation below. Should the msgid be restored to `specified`? ```suggestion msgid "Get the specified date for the holiday" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
