sadpandajoe commented on code in PR #45264: URL: https://github.com/apache/superset/pull/45264#discussion_r4279999972
########## superset/translations/ja/LC_MESSAGES/messages.po: ########## @@ -2657,7 +2697,7 @@ msgid "Bar orientation" msgstr "棒の向き" msgid "Base" -msgstr "ベース" +msgstr "基本" Review Comment: `Base` is now `基本`, but the Clause tooltip in the same RLS filter dialog (around line 16072) still tells users to create a `ベースフィルタ` for the deny-by-default `1 = 0` example. A Japanese user following that tooltip would look for a filter type named `ベース` in the Filter Type dropdown and not find it. Should the tooltip use `基本フィルター` so it matches the option label, or should this stay `ベース`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
