sadpandajoe commented on code in PR #45264:
URL: https://github.com/apache/superset/pull/45264#discussion_r4278322987
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -179,59 +195,59 @@ msgstr "% 計算"
#, python-format
msgid "% of"
-msgstr ""
+msgstr "に対する割合(%)"
Review Comment:
These `% of …` entries (here through `% of row total`, and the two `Value:
type the exact numbers…` help texts) are flagged `python-format`, and Babel
reads `% o` as a format directive that the new translations don't carry.
`pybabel compile` on this catalog now reports 11 "placeholders are
incompatible" errors (3 on master) and exits 1, so the build step fails louder
than before, and the Docker build only passes because it ends in `|| true`. `%
of total` already avoids this with `#, no-python-format`. Could the same flag
be applied to the rest of these entries?
##########
superset/translations/ja/LC_MESSAGES/messages.po:
##########
@@ -10333,22 +10392,22 @@ msgid "Opacity, expects values between 0 and 100"
msgstr "不透明度(0から100の間の値)"
msgid "Open"
-msgstr ""
+msgstr "開く"
Review Comment:
`Open`/`High`/`Low` (also lines 7822 and 9021) are the Candlestick chart's
metric control labels and tooltip rows, but they are now `開く` / `高い` / `低い`
("to open", "is high", "is low"), while this same file's help text for those
controls uses `始値` / `高値` / `安値`. A Japanese user setting up an OHLC chart
would see action/adjective labels on the controls instead of the financial
terms. Since the msgids are context-free and also used as generic labels
elsewhere, would the financial terms still read acceptably there, or should
these stay untranslated until the source strings get a context?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
