[
https://issues.apache.org/jira/browse/YETUS-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15209374#comment-15209374
]
Chris Nauroth commented on YETUS-222:
-------------------------------------
[~drankye], thank you for the patch.
As written in v1, this patch would turn on {{-Drequire.isal}} not only for
Jenkins pre-commit (which uses Docker mode), but also for any Hadoop developers
that run test-patch locally (which might or might not use Docker mode). For
developers who don't use Docker mode and don't install ISA-L, this will cause
failures, and that might be surprising.
Is that the intent, or is it better to trigger {{-Drequire.isal}} only when
running in the Docker container, where we know we always install ISA-L? On the
one hand, it would be inconsistent to treat this any differently than the other
{{-Drequire}} options. On the other hand, ISA-L is much less commonly
deployed. In my experience, there are very few developers who have this
deployed.
> hadoop: add ISA-L support
> -------------------------
>
> Key: YETUS-222
> URL: https://issues.apache.org/jira/browse/YETUS-222
> Project: Yetus
> Issue Type: Improvement
> Components: Test Patch
> Reporter: Allen Wittenauer
> Assignee: Kai Zheng
> Attachments: YETUS-222-v1.patch
>
>
> Hadoop personality should support building the native code under Jenkins when
> Docker is invoked.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
