Hi Jason, On Tue, Nov 25, 2008 at 6:32 PM, Jason Daly <[EMAIL PROTECTED]> wrote: > Well, I fundamentally disagree with you on this (I've personally had a lot > more problems with declaring variables inline), but this is more of a > philosophical argument. It's your project, so I'll play by your rules :-)
Um.... it's probably time you read a few C++ books... Your coding style is prone to uninitialized variables, scoping issues with the lifetime of objects, misuse of variables. Thankfully this style of coding is very rarely practiced by C++ these days - I don't recall merging submissions that use this style and I handle lots of submissions. If you've had problems with declaring variables when you need them then it suggests that perhaps there is other things that perhaps you could improve upon in your coding. I would recommend that you start thinking about lifetime of objects more closely, there lots of little tricks like this in C++ that are quite subtle but actually help in writing robust programs. > I took a look, the changes are fine with me. I'm pretty sure the variables > were initialized as they were, it's more likely to be a 32/64-bit problem. It might well be a 32/64bit issue. It's generally pretty easy to write code that is portable between 32/64bit, the OSG contains very very little code that is related to 32vs64bit issues. Unitialized variables is actually a far more common problem in code I see which is why I raised the flag. Robert. _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
