Hi Robert, Sukender, When enabling CTest and CDash report cmake internal script actually do try to find svn and define SVNCOMMAND. I'm not sure whether they could break each other but I don't think they will so no need to worry I'd say.
The Nightly build uses svn to restore the source tree to the state it had at midnight The Continuous build uses svn to do an update (and then reports how many files got updated mm). If lack of svn command should lead to a disabled Nightly and Continuous builds IMO is a problem for cmake and not us. I have built both Nightly and Continuous without SVNCOMMAND. For the Continuous build I got error messages in output of course but the CDash report then reported a failed update and the correct statistics on the build. This is what one can expect I think, again IMO. A proper action would be to put a link to a command-line distribution of svn. We and many others use TortoiseSVN which don't provide svn.exe but integrates with the shell (explorer). I made this work with ctest once but it just wasn't worth it. It's better to get a proper svn.exe Mattias On 1/30/09, Robert Osfield <[email protected]> wrote: > Hi Sukender, > > On Fri, Jan 30, 2009 at 12:19 PM, Sukender <[email protected]> wrote: >> OSG CMakeList.txt includes "Dart". >> Dart.cmake (standard module) includes "CTest". >> And CTest.cmake reads "FIND_PROGRAM(SVNCOMMAND svn)"... Here it is. > > Curious. There is no FIND_PROGRAM(SVNCOMMAND svn) anywhere in the > CmakeLists.txt, and a SET(SVNCOMMAND svn) so CTest must be erroneously > generating this. > >> I thus got a cache value "SVNCOMMAND" when checking "BUILD_DASHBOARDS". It >> is set to "SVNCOMMAND-NOTFOUND" on "basic" Windows machines since "svn" >> (command line executable) is either not installed or not in the path. I >> have to set it to "C:/My SVN path/bin/svn.exe". > > The nightly builds don't need anything to do with svn. svn is only > required when doing OSG_MAINTAINER task like tagging releases & > generating ChangeLogs. > > Why this should make it's way into the this I don't know. > > Robert. > > Robert. > > > > >> So, should Nightly & Continuous targets be disabled when "SVNCOMMAND" is >> not available? >> Does this variable conflicts with the one you spoke about? >> >> Sukender >> PVLE - Lightweight cross-platform game engine - >> http://pvle.sourceforge.net/ >> >> >> On Fri, 30 Jan 2009 09:36:08 +0000, Robert Osfield >> <[email protected]> wrote: >>> Hi Sukender, >>> >>> SVNCOMMAND is set within the IF (OSG_MAINTAINER) block in >>> OpenSceneGraph/CMakeLists.txt: >>> >>> SET(SVNCOMMAND svn) >>> >>> I couldn't spot where where you saw SVNCOMMAND reported as not found. >>> >>> Robert. >>> >>> >>> On Thu, Jan 29, 2009 at 11:03 PM, Sukender <[email protected]> wrote: >>>> Hi Robert, >>>> >>>> Made another build: 0 errors, 0 warnings :) ( >>>> http://www.cdash.org/CDashPublic/buildSummary.php?buildid=8061 ) >>>> >>>> I updated the CDash wiki page ( >>>> http://www.openscenegraph.org/projects/osg/wiki/Build/CDash ) by adding >>>> how to schedule a build using MSVC (not NMake). I hope it'll help >> testing >>>> more frequently. >>>> >>>> However, I noticed that if SVNCOMMAND (in CMake) is "NOTFOUND", then the >>>> Dash (Nightly & Continuous) targets are still created... which leads to >>>> something broken, as far as I know. Must this be changed? >>>> >>>> Sukender >>>> PVLE - Lightweight cross-platform game engine - >>>> http://pvle.sourceforge.net/ >>>> >>>> Le Thu, 29 Jan 2009 21:42:51 +0100, Robert Osfield >>>> <[email protected]> a écrit: >>>> >>>>> Hi All, >>>>> >>>>> I've just done my last planned checked in's for the 2.7.9 dev release. >>>>> All the MUST and should items for the 2.8.0 release have been >>>>> completed, one one could item remains. So we are in pretty good shape >>>>> for doing the feature freeze right after 2.7.9 is tagged. >>>>> >>>>> Rather than tag 2.7.9 tonight, I'll turn in, and then tomorrow morning >>>>> if all looks OK I'll check in 2.7.9 and then let this get some basic >>>>> testing, then make the 2.8 branch later on tomorrow. There on out >>>>> it's case of making 2.8.0 release candidates and testing testing >>>>> testing! >>>>> >>>>> So.. if you have a chance please test svn/trunk just to make sure ;-) >>>>> >>>>> Thanks in advance for your help, >>>>> Robert. >>>>> _______________________________________________ >>>>> osg-submissions mailing list >>>>> [email protected] >>>>> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>>> >>>> _______________________________________________ >>>> osg-submissions mailing list >>>> [email protected] >>>> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >>>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> >> _______________________________________________ >> osg-submissions mailing list >> [email protected] >> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org >> > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
