Some other litte changes just to clean up the API.

TimeLine : remove virtual inheritance that is not needed
RigGeometry : put some methods/members in private section (everything was 
public), use META_Object macro
osganimationskinning.cpp : remove two lines that are not needed

By the way, i have some good result with osgAnimation. I should post a 
screenshot soon. I still have some problems with blending for the moment...

Thanks,
Fabien

 

-----Original Message-----
From: [email protected] 
[mailto:[email protected]] On Behalf Of Cedric 
Pinson
Sent: jeudi 5 février 2009 20:03
To: OpenSceneGraph Submissions
Subject: Re: [osg-submissions] Small fixes for osgAnimation

Here the file without the virtual osg::Object

Cheers,
Cedric

Cedric Pinson wrote:
> Hi Fabien,
> Thanks for the fix, The virtual inherit from osg::Object was due some 
> previous test, it's not require.
>
> Cheers,
> Cedric
>
> Fabien Lavignotte wrote:
>> Hi Robert and Cedric,
>> Here is some various small fixes i have done while playing with 
>> osgAnimation.  - Animation : removed the _name attribute that is 
>> never used.
>>  - BasicAnimationManager : fix a crash on Windows with the example 
>> osganimationviewer. The _lastUpdate attribute was not initialized 
>> when using copy constructor.
>>  - CMakeLists.txt : add RigGeometry to the headers list And just a 
>> small comment on the Animation class, it uses virtual inheritance on 
>> osg::Object, is it really needed ?
>> Thanks,
>> Fabien Lavignotte
>>
>> _____________________________________________________________________
>> _ This email has been scanned by the MessageLabs Email Security 
>> System.
>> For more information please visit http://www.messagelabs.com/email 
>> _____________________________________________________________________
>> _
>> ---------------------------------------------------------------------
>> ---
>>
>> _______________________________________________
>> osg-submissions mailing list
>> [email protected]
>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscen
>> egraph.org
>>
>

-- 
+33 (0) 6 63 20 03 56  Cedric Pinson mailto:[email protected] 
+http://www.plopbyte.net




______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________

______________________________________________________________________
This email has been scanned by the MessageLabs Email Security System.
For more information please visit http://www.messagelabs.com/email 
______________________________________________________________________

Attachment: RigGeometry
Description: RigGeometry

Attachment: Timeline
Description: Timeline

Attachment: osganimationskinning.cpp
Description: osganimationskinning.cpp

_______________________________________________
osg-submissions mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org

Reply via email to