Hi Cedric, Could you look over these changes and if you feel they are appropriate just email me saying what parts to merge. If the changes look absolutely safe them potentially they could be merged with the OSG-2.8, otherwise merging just with svn/trunk would be appropriate.
Robert. On Mon, Feb 9, 2009 at 9:07 AM, Fabien Lavignotte <[email protected]> wrote: > Some other litte changes just to clean up the API. > > TimeLine : remove virtual inheritance that is not needed > RigGeometry : put some methods/members in private section (everything was > public), use META_Object macro > osganimationskinning.cpp : remove two lines that are not needed > > By the way, i have some good result with osgAnimation. I should post a > screenshot soon. I still have some problems with blending for the moment... > > Thanks, > Fabien > > > > -----Original Message----- > From: [email protected] > [mailto:[email protected]] On Behalf Of Cedric > Pinson > Sent: jeudi 5 février 2009 20:03 > To: OpenSceneGraph Submissions > Subject: Re: [osg-submissions] Small fixes for osgAnimation > > Here the file without the virtual osg::Object > > Cheers, > Cedric > > Cedric Pinson wrote: >> Hi Fabien, >> Thanks for the fix, The virtual inherit from osg::Object was due some >> previous test, it's not require. >> >> Cheers, >> Cedric >> >> Fabien Lavignotte wrote: >>> Hi Robert and Cedric, >>> Here is some various small fixes i have done while playing with >>> osgAnimation. - Animation : removed the _name attribute that is >>> never used. >>> - BasicAnimationManager : fix a crash on Windows with the example >>> osganimationviewer. The _lastUpdate attribute was not initialized >>> when using copy constructor. >>> - CMakeLists.txt : add RigGeometry to the headers list And just a >>> small comment on the Animation class, it uses virtual inheritance on >>> osg::Object, is it really needed ? >>> Thanks, >>> Fabien Lavignotte >>> >>> _____________________________________________________________________ >>> _ This email has been scanned by the MessageLabs Email Security >>> System. >>> For more information please visit http://www.messagelabs.com/email >>> _____________________________________________________________________ >>> _ >>> --------------------------------------------------------------------- >>> --- >>> >>> _______________________________________________ >>> osg-submissions mailing list >>> [email protected] >>> http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscen >>> egraph.org >>> >> > > -- > +33 (0) 6 63 20 03 56 Cedric Pinson mailto:[email protected] > +http://www.plopbyte.net > > > > > ______________________________________________________________________ > This email has been scanned by the MessageLabs Email Security System. > For more information please visit http://www.messagelabs.com/email > ______________________________________________________________________ > > ______________________________________________________________________ > This email has been scanned by the MessageLabs Email Security System. > For more information please visit http://www.messagelabs.com/email > ______________________________________________________________________ > _______________________________________________ > osg-submissions mailing list > [email protected] > http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org > > _______________________________________________ osg-submissions mailing list [email protected] http://lists.openscenegraph.org/listinfo.cgi/osg-submissions-openscenegraph.org
