Hi Thomas,
Congrats on getting the OSG up and running on the iPhone. I'm
currently reviewing your changes, and will probably introduce the
changes bit by bit, with parts requiring a little refactoring along
the way - for these we'll need so to and fro between us to settle upon
final code.
First up I have a few questions:
1) #include "TargetConditionals.h"
Does this header exist on all versions of OSX? Or is it just for iPhone?
2) The OSG's existing XCode projects and deprecated, with CMake being the route
we've been planning to the way to generate XCode projects.
Have you looked at trying to use CMake on the IPhone? Looking on
the web it looks like
others are already doing this for other open source projects so I
believe it should be possible.
3) In src/osgDB/FileUtils.cpp you've added an #import
<Foundation/Foundation.h> which isn't
guarded at all so it'll break the build on other platforms. I
presume this is a Objective C line,
does this require gcc options under OSX to get it build cleanly?
Later in the OSX specific code path there is an #include
<Foundation/Foundation.h> so
perhaps this would be OK for the Iphone as well if the ordering of
the includes was changed.
4) In include/osg/GL you've added a glReadBuffer implementation. For
the other GLES
platforms I didn't need this as the examples/OSG lib code so I
presume either I've missed
something or that you've not go the OSG_GLES1_AVAILABLE macro
defined correctly.
Which parts of the OSG didn't build without this addtion to include/osg/GL?
I'll keep doing my review and merge the parts that shouldn't cause any
build issues.
Cheers,
Robert.
_______________________________________________
osg-users mailing list
[email protected]
http://lists.openscenegraph.org/listinfo.cgi/osg-users-openscenegraph.org
