[PD-dev] two patches for pd vanilla and pd-extended 0.42.5

[Ivica Ico Bukvic]

Here are two patches for g_editor.c that fix following issues in 0.42.5:

1) undo recreates patch cords with wrong color (I posted this one
earlier by mistake on the pd-list)

2) graph on parent (GOP) enable and then immediately disable crashes
patches that haven't been closed prior to disabling GOP (to reproduce,
open new patch->right-click->properties->enable gop->apply->disable
gop->apply->crash). This one may also affect pd vanilla (haven't
checked)

Best wishes,

ico

--- g_editor_old.c	2009-10-30 22:13:16.000000000 -0400
+++ g_editor.c	2009-10-31 13:34:00.000000000 -0400
@@ -909,11 +909,15 @@ void canvas_destroy_editor(t_glist *x)
     t_object *ob;
     if (x->gl_editor)
     {
-        for (y = x->gl_list; y; y = y->g_next)
-            if (ob = pd_checkobject(&y->g_pd))
-                rtext_free(glist_findrtext(x, ob));
-        editor_free(x->gl_editor, x);
-        x->gl_editor = 0;
+		if (x->gl_list) {
+        	for (y = x->gl_list; y; y = y->g_next)
+        	    if (ob = pd_checkobject(&y->g_pd))
+        	        rtext_free(glist_findrtext(x, ob));
+			if (x->gl_editor) {
+				editor_free(x->gl_editor, x);
+				x->gl_editor = 0;
+			}
+		}
     }
 }


--- g_editor_old.c	2009-10-30 22:13:16.000000000 -0400
+++ g_editor.c	2009-10-30 22:13:40.000000000 -0400
@@ -2472,9 +2472,9 @@ void canvas_connect(t_canvas *x, t_float
     if (!(oc = obj_connect(objsrc, outno, objsink, inno))) goto bad;
     if (glist_isvisible(x))
     {
-        sys_vgui(".x%lx.c create line %d %d %d %d -width %d -tags l%lx\n",
+        sys_vgui(".x%lx.c create line %d %d %d %d -width %d -fill %s -tags l%lx\n",
             glist_getcanvas(x), 0, 0, 0, 0,
-            (obj_issignaloutlet(objsrc, outno) ? 2 : 1),oc);
+            (obj_issignaloutlet(objsrc, outno) ? 2 : 1), (obj_issignaloutlet(objsrc, outno) ? "$signal_cord" : "$msg_cord"), oc);
         canvas_fixlinesfor(x, objsrc);
     }
     return;

_______________________________________________
Pd-dev mailing list
Pd-dev@iem.at
http://lists.puredata.info/listinfo/pd-dev