On Sat, 2009-10-31 at 13:39 -0400, Ivica Ico Bukvic wrote:
> Here are two patches for g_editor.c that fix following issues in 0.42.5:
> 
> 1) undo recreates patch cords with wrong color (I posted this one
> earlier by mistake on the pd-list)
> 
> 2) graph on parent (GOP) enable and then immediately disable crashes
> patches that haven't been closed prior to disabling GOP (to reproduce,
> open new patch->right-click->properties->enable gop->apply->disable
> gop->apply->crash). This one may also affect pd vanilla (haven't
> checked)

Oops, discovered another bug:

New patcher->create [pd something]->inside new patcher create any object
(e.g. symbol) and leave it selected->right-click on
canvas->properties->enable gop->apply->disable gop->apply->crash

New patch should supersede the previous patch for the second point
fixing this problem as well.

Ico
--- g_editor_old.c	2009-10-30 22:13:16.000000000 -0400
+++ g_editor.c	2009-10-31 14:01:29.000000000 -0400
@@ -907,13 +907,18 @@ void canvas_destroy_editor(t_glist *x)
 {
     t_gobj *y;
     t_object *ob;
+	glist_noselect(x);
     if (x->gl_editor)
     {
-        for (y = x->gl_list; y; y = y->g_next)
-            if (ob = pd_checkobject(&y->g_pd))
-                rtext_free(glist_findrtext(x, ob));
-        editor_free(x->gl_editor, x);
-        x->gl_editor = 0;
+		if (x->gl_list) {
+        	for (y = x->gl_list; y; y = y->g_next)
+        	    if (ob = pd_checkobject(&y->g_pd))
+        	        rtext_free(glist_findrtext(x, ob));
+			if (x->gl_editor) {
+				editor_free(x->gl_editor, x);
+				x->gl_editor = 0;
+			}
+		}
     }
 }
_______________________________________________
Pd-dev mailing list
Pd-dev@iem.at
http://lists.puredata.info/listinfo/pd-dev

Reply via email to