dcapwell commented on code in PR #3954: URL: https://github.com/apache/cassandra/pull/3954#discussion_r1982393798
########## src/java/org/apache/cassandra/net/Verb.java: ########## @@ -630,6 +634,16 @@ private static int idForCustomVerb(int id) { return CUSTOM_VERB_START - id; } + + private static <A, B> IVersionedAsymmetricSerializer<A, B> accordEmbedded(AsymmetricVersionedSerializer<A, B, Version> delegate) Review Comment: something now properly handled in this patch is figuring out what version to use. In some code paths we have relied on node version to infer what capabilities are present. There is a ML thread about adding capabilities into C*, which would let us denote what versions are supported by which notes... for now this logic is mostly a place holder -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org