dcapwell commented on code in PR #3954: URL: https://github.com/apache/cassandra/pull/3954#discussion_r1982398315
########## src/java/org/apache/cassandra/service/accord/AccordSerializers.java: ########## @@ -54,23 +57,24 @@ import static org.apache.cassandra.db.marshal.CollectionType.Kind.LIST; import static org.apache.cassandra.db.marshal.CollectionType.Kind.MAP; import static org.apache.cassandra.db.marshal.CollectionType.Kind.SET; +import static org.apache.cassandra.utils.ByteBufferUtil.nullableByteBufferSerializer; public class AccordSerializers { + public static <T> EmbeddedAsymmetricVersionedSerializer<T, T, Version> embedded(VersionedSerializer<T, Version> serializer) Review Comment: TODO: remove these methods, they are kinda unsafe as we odn't know the best version to use at this layer -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org