dcapwell commented on code in PR #3954:
URL: https://github.com/apache/cassandra/pull/3954#discussion_r1985446586
##########
src/java/org/apache/cassandra/service/accord/interop/AccordInteropReadRepair.java:
##########
@@ -111,11 +112,11 @@ Object convertResponse(ReadOk ok)
private static final IVersionedSerializer<Data> noop_data_serializer = new
IVersionedSerializer<>()
{
@Override
- public void serialize(Data t, DataOutputPlus out, int version) throws
IOException {}
+ public void serialize(Data t, DataOutputPlus out, Version version)
throws IOException {}
Review Comment:
even though this could be unversioned, the usage of it uses the same class
for replies and that does have a version, so making this unversioned would
complicate `ReadDataSerializers.ReplySerializer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org
For additional commands, e-mail: pr-h...@cassandra.apache.org
