dcapwell commented on code in PR #3954: URL: https://github.com/apache/cassandra/pull/3954#discussion_r1982394448
########## src/java/org/apache/cassandra/service/accord/AccordCache.java: ########## @@ -1212,7 +1212,7 @@ public Object fullShrink(TxnId txnId, Command value) try { - return AccordJournal.asSerializedChange(null, value, current_version); + return AccordJournal.asSerializedChange(null, value, Version.LATEST); Review Comment: TODO: is this in-memeory or a disk cache? if disk we shouldn't use `latest` but instead a downgrade safe version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: pr-unsubscr...@cassandra.apache.org For additional commands, e-mail: pr-h...@cassandra.apache.org