The main problem is with the use of name.camelize() in the final call to element.style[] = value;
Without the camelization of the name everything works must faster. I personally always camelize the values in the object i pass to setStyle before hand, instead of having the key as a string. Maybe either deprecating the use of none camelized keys. or checking if it needs to be done in the first place? On 2/18/07, Mislav Marohnić <[EMAIL PROTECTED]> wrote: > On 2/18/07, Martin Ellis <[EMAIL PROTECTED]> wrote: > > > > I fully understand the argument for premature optimisation. But for me > > it, its late optimisation, really i needed the performance out of the > > box. > > Optimizing getStyle and setStyle methods would not be premature, but a very > welcome optimization at this point. But it will not be easy. I tried to do > it in #6696 and Marius took a different approach in #6705 (w/ benchmarks!!), > Tobie spent days on these two methods, and still they hold room for much > improvement. > > Any optimization must preserve code readability and beauty (think > maintainability) and compactness of the framework. > > -- > p.s. Marius: about > http://gfx.neohub.com/benchmark/t/isin.html ... holy crap, > this is damn sweet!! Your benchmark lib is growing? :) > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Prototype: Core" group. To post to this group, send email to prototype-core@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/prototype-core?hl=en -~----------~----~----~----~------~----~------~--~---
