Looking at GenericSideEffect I do not see the added value of having this class beside the small benefit of the fact that by inheriting it you get the extends of SideEffectOd and implements InvocationHandler. Can it be that is there for a future use where we could add something to it and so all the subclasses will inherit it? Also by looking at it's usage only the trivial examples overrides the method/args/void return method. The more complex ones need the proxy so it overrides the InvocationHandler method, basically not reusing anything from GenericSideEffect. I suggest that we get rid of this class or make the InvocationHandler method final and the other one abstract so we kind force it's usage. And those that need the proxy should directly inherit from SideEffectOf.
-- Alin Dreghiciu http://www.ops4j.org - New Energy for OSS Communities - Open Participation Software. http://www.qi4j.org - New Energy for Java - Domain Driven Development. http://malaysia.jayway.net - New Energy for Projects - Great People working on Great Projects at Great Places _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
