Sounds good: +1 Michael Niclas Hedhman schrieb: > On Thu, Jun 12, 2008 at 5:58 PM, Alin Dreghiciu <[EMAIL PROTECTED]> wrote: >> Looking at GenericSideEffect I do not see the added value of having >> this class beside the small benefit of the fact that by inheriting it >> you get the extends of SideEffectOd and implements InvocationHandler. >> Can it be that is there for a future use where we could add something >> to it and so all the subclasses will inherit it? > > I think we should redo it so that there are protected methods; > > protected abstract void beforeInvoke( Method method, Object[] args); > > protected abstract void onSuccess( Object returnValue ); > > protected abstract void onException( Throwable exception ); > > > or something like that and make the invoke() final, as suggested. > > > Cheers > Niclas > > _______________________________________________ > qi4j-dev mailing list > [email protected] > http://lists.ops4j.org/mailman/listinfo/qi4j-dev
-- Michael Hunger Independent Consultant Web: http://www.jexp.de Email: [EMAIL PROTECTED] Enthusiastic Evangelist for Better Software Development Don't stop where you are: http://creating.passionate-developers.org We support Software Engineering Radio (www.se-radio.net) _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
