If we would go for Niclas proposal I'm for empty methods too, but I would rather go for not having this GenericSideEfect/GenericConcern at all as I do not see a real plus in having them.
Regarding the Niclas 3 methods, I'm voting -1 as it will force sharing the state at instance level instead of method variable in case that I need such state. E.g. logging the execution time. Alin On Fri, Jun 13, 2008 at 2:37 PM, Michael Hunger <[EMAIL PROTECTED]> wrote: > Oh, perhaps not as abstact methods but with an empty default implementation, > so that you can but mustn't implement them > (according to your needs). > > Michael > > Michael Hunger schrieb: >> Sounds good: +1 >> >> Michael >> Niclas Hedhman schrieb: >>> On Thu, Jun 12, 2008 at 5:58 PM, Alin Dreghiciu <[EMAIL PROTECTED]> wrote: >>>> Looking at GenericSideEffect I do not see the added value of having >>>> this class beside the small benefit of the fact that by inheriting it >>>> you get the extends of SideEffectOd and implements InvocationHandler. >>>> Can it be that is there for a future use where we could add something >>>> to it and so all the subclasses will inherit it? >>> I think we should redo it so that there are protected methods; >>> >>> protected abstract void beforeInvoke( Method method, Object[] args); >>> >>> protected abstract void onSuccess( Object returnValue ); >>> >>> protected abstract void onException( Throwable exception ); >>> >>> >>> or something like that and make the invoke() final, as suggested. >>> >>> >>> Cheers >>> Niclas >>> >>> _______________________________________________ >>> qi4j-dev mailing list >>> [email protected] >>> http://lists.ops4j.org/mailman/listinfo/qi4j-dev >> >> > > > _______________________________________________ > qi4j-dev mailing list > [email protected] > http://lists.ops4j.org/mailman/listinfo/qi4j-dev > -- Alin Dreghiciu http://www.ops4j.org - New Energy for OSS Communities - Open Participation Software. http://www.qi4j.org - New Energy for Java - Domain Driven Development. http://malaysia.jayway.net - New Energy for Projects - Great People working on Great Projects at Great Places _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
