Niclas Hedhman wrote: > On Thu, Jun 12, 2008 at 5:58 PM, Alin Dreghiciu <[EMAIL PROTECTED]> wrote: >> Looking at GenericSideEffect I do not see the added value of having >> this class beside the small benefit of the fact that by inheriting it >> you get the extends of SideEffectOd and implements InvocationHandler. >> Can it be that is there for a future use where we could add something >> to it and so all the subclasses will inherit it? > > I think we should redo it so that there are protected methods; > > protected abstract void beforeInvoke( Method method, Object[] args); > > protected abstract void onSuccess( Object returnValue ); > > protected abstract void onException( Throwable exception ); > > > or something like that and make the invoke() final, as suggested.
Like Alin said, this would only make sense for GenericConcern, not GenericSideEffect. The problem with this kind of construct is that it creates a small but unnecessary performance cost, since it will be invoking a couple of no-op methods for no good reason. It's easy enough to do the above manually. I'd say -1 on these for now. They are easy to add later if some really good arguments come up. /Rickard _______________________________________________ qi4j-dev mailing list [email protected] http://lists.ops4j.org/mailman/listinfo/qi4j-dev
