On Nov 2, 12:53 am, "Christian Hammond" <[EMAIL PROTECTED]> wrote:

> Yeah. What basically happens is that Review Board will check either the
>
> main repository path or the mirror path when looking up a repository (say,
> from post-review), but will use the mirror path (if set) for the actual
> calls to the server. (Why it uses the mirror path and not the main one, I
> don't recall anymore -- I think it was due to how we had things set up at
> VMware originally to work around something).

Hm.  I'm having trouble getting it to actually behave this way.  I
have a repository set up with the main path as https://origsvn..., as
that is where all of my checkouts will be from.  Then, I set my mirror
path to be http://svn..., since that is the public mirror that
reviewboard actually has access to.  post-review from my https://
checkout works fine, but viewing the diff does not work.  It looks
like it's making calls to the server using the main repo path instead
of the mirror path.  Here is the trace.  I'll see if I can figure out
what to change in the code in the meantime ...

PROPFIND request failed on '/svn/asterisk/trunk/apps/app_rpt.c'
PROPFIND of '/svn/asterisk/trunk/apps/app_rpt.c': SSL negotiation
failed: SSL error: sslv3 alert handshake failure (https://
origsvn.digium.com)

Traceback (most recent call last):
  File "/home/russell/src/reviewboard/diffviewer/views.py", line 86,
in view_diff
    files = get_diff_files(diffset, None, interdiffset, highlighting)
  File "/home/russell/src/reviewboard/diffviewer/diffutils.py", line
654, in get_diff_files
    enable_syntax_highlighting)
  File "/home/russell/src/reviewboard/diffviewer/diffutils.py", line
573, in generate_files
    large_data=True)
  File "/home/russell/src/reviewboard/djblets/util/misc.py", line 142,
in cache_memoize
    data = lookup_callable()
  File "/home/russell/src/reviewboard/diffviewer/diffutils.py", line
572, in <lambda>
    enable_syntax_highlighting),
  File "/home/russell/src/reviewboard/diffviewer/diffutils.py", line
338, in get_chunks
    old = get_original_file(filediff)
  File "/home/russell/src/reviewboard/diffviewer/diffutils.py", line
245, in get_original_file
    large_data=True)[0]
  File "/home/russell/src/reviewboard/djblets/util/misc.py", line 142,
in cache_memoize
    data = lookup_callable()
  File "/home/russell/src/reviewboard/diffviewer/diffutils.py", line
244, in <lambda>
    data = cache_memoize(key, lambda: [fetch_file(file, revision)],
  File "/home/russell/src/reviewboard/diffviewer/diffutils.py", line
224, in fetch_file
    data = tool.get_file(file, revision)
  File "/home/russell/src/reviewboard/scmtools/svn.py", line 115, in
get_file
    raise SCMError(e)
SCMError: PROPFIND request failed on '/svn/asterisk/trunk/apps/
app_rpt.c'
PROPFIND of '/svn/asterisk/trunk/apps/app_rpt.c': SSL negotiation
failed: SSL error: sslv3 alert handshake failure (https://
origsvn.digium.com)

--
Russell Bryant
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to