In which file would I look to remove the param? I am using a Windows environment.
Thanks, Tim From: reviewboard@googlegroups.com [mailto:reviewbo...@googlegroups.com] On Behalf Of Christian Hammond Sent: August-19-10 8:43 PM To: reviewboard@googlegroups.com Subject: Re: post-review error with svn and gnu diffutils (new review with an added binary file) There's no way to pass additional arguments right now. Personally I don't like that we even use --diff-cmd, but it works around some other problems we've hit in the past (I'd have to check the commit logs to remember exactly what they were). It may be worth modifying your copy for now to remove that parameter, if it's blocking you. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Thu, Aug 19, 2010 at 5:42 AM, Timothy Pinet <tim.pi...@gmail.com> wrote: Alternatively, the diffutils docs (http://www.gnu.org/software/hello/ <http://www.gnu.org/software/hello/%0Amanual/diff.html#Binary> manual/diff.html#Binary) state: "Differing binary files are considered to cause trouble because the resulting diff output does not capture all the differences. This trouble causes diff to exit with status 2. However, this trouble cannot occur with the --a or --text option, or with the -q or --brief option, as these options both cause diff to treat binary files like text files." Can post-review call svn diff with the -a option? Is there a way that I can tell it to do that in config? I believe the reason is that the svn:mime-type property is not set correctly on the binary file and svn diff is trying to text diff it. Thanks, Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com <mailto:reviewboard%2bunsubscr...@googlegroups.com> For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
