Thanks for the suggestion. I downloaded rbtools 0.2 stable from http://github.com/reviewboard/rbtools, made my changes to postreview.py, and reinstalled the package using "python setup.py install" at the rbtool root.
In postreview.py I changed the "svn diff --diff-cmd=diff" to "svn diff --diff-cmd=C:\\diffForceText.bat" and recompiled. I create the wrapper script "diffForceText.bat" to simply include: ================================ @echo off diff %* --text ================================ Which forwards all calls into GNU diff but forces the --text param. This overcomes my binary file being text diffed and returning exit code 2 to SVN diff. I now have a fully working ReviewBoard + Windows + TFS repo solution for my org and it is blowing minds and melting faces. I will post how I got TFS to work as it was not very straight forward. Tim -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~----------~----~----~----~------~----~------~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
