Re help: the order of the 'manage' and <path> arguments is swapped. Correct order: rb-site manage <path> Help message: rb-site <path> manage
Regards, Alexey. On Wed, Sep 24, 2014 at 12:41 PM, Christian Hammond < christ...@beanbaginc.com> wrote: > Thanks, I'll fix the release notes. > > Make sure to put a -- before any --arguments, like: > > rb-site manage /var/www/reviewboard reset-issue-counts -- > --verbosity=2 --recalculate > > Not sure what you mean by the help output being wrong though? > > Christian > > -- > Christian Hammond - christ...@beanbaginc.com > Review Board - https://www.reviewboard.org > Beanbag, Inc. - https://www.beanbaginc.com > > > On September 24, 2014 at 12:40:11 PM, Alexey Neyman ( > alexey.ney...@gmail.com) wrote: > > Hi Christian, > > > > Just upgraded to 2.0.8: > > > > [[[ > > bash-4.1# rb-site manage /var/www.reviewboard reset-issue-counts > > --recalculate --verbosity=2 2050 > > Usage: rb-site command [options] path > > > > rb-site: error: no such option: --recalculate > > bash-4.1# rb-site --version > > rb-site 2.0.8 > > ]]] > > > > BTW, release notes for 2.0.8 seem to omit the 'manage' argument from the > > command line: > > > > rb-site reset-issue-counts --recalculate --verbosity=2 > > > > Also, the usage in --help message is wrong: it suggests to use 'rb-site > > manage command' - while the correct order is 'rb-site manage > > command'. > > > > Regards, > > Alexey. > > > > > > > > On Wed, Sep 24, 2014 at 10:28 AM, Christian Hammond < > > christ...@beanbaginc.com> wrote: > > > > > Hey, > > > > > > 2.0.8 contains a new reset-issue-counts management command that can be > > > used. I takes a list of IDs, or --all to reset all review requests. > Issue > > > counts will be recalculated on next access. > > > > > > It can also provide debug info about the calculations. Can you find > one of > > > the miscalculated review requests and run: > > > > > > rb-site manage /path/to/site reset-issue-counts -- -verbosity=2 > > > --recalculate > > > > > > See if the counts are right and then paste the debug output from that > > > command. It'll help me get a sense of what's going wrong (hopefully). > > > > > > (Also, I added basic --help output to rb-site for the "manage" > command.) > > > > > > Christian > > > > > > -- > > > Christian Hammond - christ...@beanbaginc.com > > > Review Board - https://www.reviewboard.org > > > Beanbag, Inc. - https://www.beanbaginc.com > > > > > > > > > On September 23, 2014 at 4:29:54 PM, Christian Hammond ( > > > christ...@beanbaginc.com) wrote: > > > > Oh, regarding the "fix the counts" script, I can write one, but it's > > > very unlikely to matter, > > > > I realized. It's just going to trigger the exact same logic that's > > > triggered when viewing > > > > the review request for the first time, post-upgrade. If it got it > wrong > > > before, I don't > > > > have much reason to believe it'll get it right the next time. > > > > > > > > I'll have to fix the bug properly. For that, I'll probably need a > > > before/after or a solid > > > > repro case. > > > > > > > > Christian > > > > > > > > -- > > > > Christian Hammond - christ...@beanbaginc.com > > > > Review Board - https://www.reviewboard.org > > > > Beanbag, Inc. - https://www.beanbaginc.com > > > > > > > > > > > > On September 23, 2014 at 4:21:23 PM, Christian Hammond ( > > > christ...@beanbaginc.com) > > > > wrote: > > > > > Do you happen to have a database backup prior to the upgrade? I'd > love > > > to try with a real > > > > > before/after. > > > > > > > > > > Christian > > > > > > > > > > -- > > > > > Christian Hammond - christ...@beanbaginc.com > > > > > Review Board - https://www.reviewboard.org > > > > > Beanbag, Inc. - https://www.beanbaginc.com > > > > > > > > > > > > > > > On September 22, 2014 at 4:15:20 PM, Christian Hammond ( > > > christ...@beanbaginc.com) > > > > > wrote: > > > > > > Hi Alexey, > > > > > > > > > > > > That's something we can get in. > > > > > > > > > > > > As for the manage command, it's just an oversight. > > > > > > > > > > > > Christian > > > > > > > > > > > > -- > > > > > > Christian Hammond - christ...@beanbaginc.com > > > > > > Review Board - https://www.reviewboard.org > > > > > > Beanbag, Inc. - https://www.beanbaginc.com > > > > > > > > > > > > > > > > > > On September 22, 2014 at 3:09:41 PM, Alexey Neyman ( > > > alexey.ney...@gmail.com) wrote: > > > > > > > Christian, > > > > > > > > > > > > > > Meanwhile, is it possible to have a rb-site manage subcommand > to > > > > > > > recalculate these counters? > > > > > > > > > > > > > > Thanks, > > > > > > > Alexey. > > > > > > > On Sep 22, 2014 2:00 PM, "Christian Hammond" wrote: > > > > > > > > > > > > > > > > I would love a repro case for this. I've seen a couple of > > > reports, and > > > > > > > have tried desperately to reproduce it, with no luck. The code > is > > > fairly > > > > > > > straightforward in how it counts the initial values. > > > > > > > > > > > > > > > > Christian > > > > > > > > > > > > > > > > On Monday, September 22, 2014, Stephen Gallagher < > > > > > > > step...@gallagherhome.com> wrote: > > > > > > > >> > > > > > > > >> On 09/22/2014 04:30 PM, Alexey Neyman wrote: > > > > > > > >> > Hi all, > > > > > > > >> > > > > > > > > >> > We have just upgraded our installation of RB to 2.0.7. One > > > nice new > > > > > > > >> > feature is that the dashboard now displays the number of > open > > > issues in > > > > > > > >> > a review request. > > > > > > > >> > > > > > > > > >> > However, I have noticed that the counters don't seem to be > > > accurate in > > > > > > > >> > some request. For example, one of the review requests has > 4 > > > reviews > > > > > > > with > > > > > > > >> > ship-its, with 2 of them making a comment on the code > which > > > were not > > > > > > > >> > marked as issues. Yet, the status displayed in the > dashboard > > > is "1 open > > > > > > > >> > issue". I verified this in admin/database/review requests, > > > and this > > > > > > > >> > review request is indeed recorded as having "ship-it > count: > > > 4" and > > > > > > > "open > > > > > > > >> > issue count: 1". > > > > > > > >> > > > > > > > > >> > > > > > > > >> I've hit the same bug on one of my deployments, but I > haven't > > > been able > > > > > > > >> to reproduce it yet. > > > > > > > >> > > > > > > > >> > > > > > > > >> > I am not sure if this was a 1.7 bug, or if it was caused > by > > > the upgrade > > > > > > > >> > - the request and some of the reviews were submitted > before > > > the RB > > > > > > > >> > upgrade. However, I am not sure if the rest of the > counters > > > are valid - > > > > > > > >> > going through all the requests and verifying them > manually is > > > obviously > > > > > > > >> > a lot of work. So, is there a way to make RB recalculate > > > these counters > > > > > > > >> > - like it was with the dashboard counters and the "rb-site > > > manage > > > > > > > >> > /path/to/site fixreviewcounts" command? > > > > > > > >> > > > > > > > > >> > As a side note, it seems that the 'rb-site --help' message > > > does not > > > > > > > >> > mention the 'manage' command at all. Is it intentional or > an > > > oversight? > > > > > > > >> > > > > > > > > >> > Regards, > > > > > > > >> > Alexey. > > > > > > > >> > > > > > > > > >> > -- > > > > > > > >> > Get the Review Board Power Pack at > > > > > > > http://www.reviewboard.org/powerpack/ > > > > > > > >> > --- > > > > > > > >> > Sign up for Review Board hosting at RBCommons: > > > https://rbcommons.com/ > > > > > > > >> > --- > > > > > > > >> > Happy user? Let us know at > http://www.reviewboard.org/users/ > > > > > > > >> > --- > > > > > > > >> > You received this message because you are subscribed to > the > > > Google > > > > > > > >> > Groups "reviewboard" group. > > > > > > > >> > To unsubscribe from this group and stop receiving emails > from > > > it, send > > > > > > > >> > an email to reviewboard+unsubscr...@googlegroups.com > > > > > > > >> > . > > > > > > > >> > For more options, visit > https://groups.google.com/d/optout. > > > > > > > >> > > > > > > > >> -- > > > > > > > >> Get the Review Board Power Pack at > > > http://www.reviewboard.org/powerpack/ > > > > > > > >> --- > > > > > > > >> Sign up for Review Board hosting at RBCommons: > > > https://rbcommons.com/ > > > > > > > >> --- > > > > > > > >> Happy user? Let us know at > http://www.reviewboard.org/users/ > > > > > > > >> --- > > > > > > > >> You received this message because you are subscribed to the > > > Google > > > > > > > Groups "reviewboard" group. > > > > > > > >> To unsubscribe from this group and stop receiving emails > from > > > it, send > > > > > > > an email to reviewboard+unsubscr...@googlegroups.com. > > > > > > > >> > > > > > > > >> For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > > -- > > > > > > > > Christian Hammond - chip...@chipx86.com > > > > > > > > Review Board - http://www.reviewboard.org > > > > > > > > Beanbag, Inc. - http://www.beanbaginc.com > > > > > > > > > > > > > > > > -- > > > > > > > > Get the Review Board Power Pack at > > > http://www.reviewboard.org/powerpack/ > > > > > > > > --- > > > > > > > > Sign up for Review Board hosting at RBCommons: > > > https://rbcommons.com/ > > > > > > > > --- > > > > > > > > Happy user? Let us know at http://www.reviewboard.org/users/ > > > > > > > > --- > > > > > > > > You received this message because you are subscribed to a > topic > > > in the > > > > > > > Google Groups "reviewboard" group. > > > > > > > > To unsubscribe from this topic, visit > > > > > > > > > > https://groups.google.com/d/topic/reviewboard/LKmrIXZGuDI/unsubscribe. > > > > > > > > To unsubscribe from this group and all its topics, send an > email > > > to > > > > > > > reviewboard+unsubscr...@googlegroups.com. > > > > > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > > > > > -- > > > > > > > Get the Review Board Power Pack at > > > http://www.reviewboard.org/powerpack/ > > > > > > > --- > > > > > > > Sign up for Review Board hosting at RBCommons: > > > https://rbcommons.com/ > > > > > > > --- > > > > > > > Happy user? Let us know at http://www.reviewboard.org/users/ > > > > > > > --- > > > > > > > You received this message because you are subscribed to the > Google > > > Groups "reviewboard" > > > > > > > group. > > > > > > > To unsubscribe from this group and stop receiving emails from > it, > > > send an email to > > > > reviewboard+unsubscr...@googlegroups.com. > > > > > > > For more options, visit https://groups.google.com/d/optout. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
