Alexey Serbin has posted comments on this change. Change subject: MiniKdc for C++ ......................................................................
Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/4752/3/src/kudu/security/CMakeLists.txt File src/kudu/security/CMakeLists.txt: Line 33: ADD_KUDU_TEST(mini_kdc-test) > I don't think it's viable in the long term to limit tests requiring KDC, no It seems the parallel conversation was around find_package(Kdc) line. :) Yes, I think your reasoning makes sense if thinking about long-term goals. http://gerrit.cloudera.org:8080/#/c/4752/3/src/kudu/security/mini_kdc.cc File src/kudu/security/mini_kdc.cc: PS3, Line 220: udp_preference_limit = 0 > I think we still want this, otherwise the client will prefer connecting to I don't know much about this, but I would think if client is given the same config, it would understand that the server does not listen on UDP ports. However, I haven't tried that and cannot say for sure. That said, I think it's reasonable to keep this option :) PS3, Line 287: "-q" > See my reply on the previous revision. Yep, thanks. It seems I'm lost in my comments for different revisions. Sorry for the inconsistency. -- To view, visit http://gerrit.cloudera.org:8080/4752 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I63fc53eeaa1e40b217030adc1ca0c132f43a076c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
