Adar Dembo has posted comments on this change. Change subject: [util] fixed env-test on OS X ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1274: uint64_t limit = 0; Hmm, is it possible that uint64_t is the wrong type, and we should be using uint32_t to begin with? Or maybe we should be consulting len after the call to see how many bytes were actually written? If not, could you document this strange behavior of sysctlbyname in a short comment here? Also, is this behavior deterministic on all OS X 10.11? Or does it write all 64-bits in some subversions? -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
