Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1274: uint64_t limit = 0; > Using uint32_t should be OK because if for some reason the kernel begins ex Well, sysctlbyname() never reads the oldp. However, given this standard 'read-into-a-scratchpad' scenario usually means you need to prepare/wipe the scratchpad before you pass it to the writer. Ok, I'll remove the initialization, but I'll add a check to make sure the result size of the written data is not less than the size of the scratchpad variable. -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
