Adar Dembo has posted comments on this change. Change subject: [util] fixed env-test on OS X ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1274: uint32_t limit = 0; > I don't think we need to do call of sysctlbyname("kern.maxfilesperproc", nu Using uint32_t should be OK because if for some reason the kernel begins expecting a 64-bit integer, it'll return ENOMEM and we'll crash here. But, could you remove the initialization of limit to 0? It's harmless, but it could be misinterpreted as signalling that sysctlbyname() reads the existing value of oldp, which it doesn't. -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
