Dinesh Bhat has posted comments on this change. Change subject: [util] fixed env-test on OS X ......................................................................
Patch Set 2: (2 comments) I am not seeing radio buttons on gerrit, perhaps some browser plugin issue I am facing at the moment, so consider +1 from my side. http://gerrit.cloudera.org:8080/#/c/5738/2//COMMIT_MSG Commit Message: Line 14: Do you want to post the stacktrace of the failure ? http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1277: l.rlim_max = limit; > I'm not following: why would the rlimit struct be relevant here? The probl Calling setrlimit down below with astronomical value was the original cause; So if rlim_max was uninitialized, 'rlim_max(uint64_t) = limit(uint32_t)' here will end up in same issue. But ignore this, I just confirmed that structs come with default constructors too, so this is safe. -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
