Dinesh Bhat has posted comments on this change. Change subject: [util] fixed env-test on OS X ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1274: uint64_t limit = 0; > On-line man page for sysctlbyname() on OS X: +1 for what Adar said above, man page also seem to state this: "The size of the available data can be determined by calling sysctl() with the NULL argument for oldp. The size of the available data will be returned in the location pointed to by oldlenp. For some opera-tions, operations, tions, the amount of space may change often. For these operations, the system attempts to round up so that the returned size is large enough for a call to return the data shortly thereafter. " Although this system parameter may not change its size at run time, we could always query the size of the data about to be written and allocate uint32 or uint64 based on what's returned by sysctl. Line 1277: l.rlim_max = limit; thinking aloud, rlim_max is a uint64_t struct variable, so I am hoping that structs have default constructors for the initialization of this variable before this assignment. -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
