Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X ......................................................................
Patch Set 2: (2 comments) Thank you for the review. http://gerrit.cloudera.org:8080/#/c/5738/2//COMMIT_MSG Commit Message: Line 14: > Do you want to post the stacktrace of the failure ? Nope, I don't want to post the stacktrace of the failure. IMO, doing so would not bring any value; it would just break the formatting of the commit message. http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1277: l.rlim_max = limit; > Calling setrlimit down below with astronomical value was the original cause Let me clarify: the 'rlim_max' _was_ initialized -- it was assigned the 'limit' value, where the 'limit' value was obtained from call to sysctlbyname(), which you can see from line 1277 of the code. The problem was that the 'limit' 64-bit variable passed to the sysctlbyname() was wider than the output of the function and those un-initialized extra bits were non-zero. That ended up as passing astronomical values in l.rlim_max. -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
