Alexey Serbin has posted comments on this change. Change subject: [util] fixed env-test on OS X ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/5738/2/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: Line 1274: uint64_t limit = 0; > +1 for what Adar said above, man page also seem to state this: I don't think we need to do call of sysctlbyname("kern.maxfilesperproc", nullptr, &len, ...) to discover the proper size of the variable -- the manual page has it documented as 32-bit integer. If, for some reason, they change that in the future releases and 32 bits is not enough, the sysctlbyname() should return ENOMEM and the CHECK() will fire. So, it's all safe. Line 1277: l.rlim_max = limit; > thinking aloud, rlim_max is a uint64_t struct variable, so I am hoping that I'm not following: why would the rlimit struct be relevant here? The problem was in variable passed to sysctlbyname() itself. -- To view, visit http://gerrit.cloudera.org:8080/5738 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic355912b98b3fa592481e2457147e23de98447ea Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dinesh Bhat <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
