Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 )
Change subject: error_manager: synchronize/serialize handling ...................................................................... Patch Set 4: (3 comments) Revving with some updates, not good for review yet. http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h@96 PS4, Line 96: etesbefore nit: space http://gerrit.cloudera.org:8080/#/c/8395/3/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/8395/3/src/kudu/fs/error_manager.h@84 PS3, Line 84: enum ErrorHandlerType { > Could you start a error_manager.cc file and move most (if not all?) of the Ah, sorry I missed this. http://gerrit.cloudera.org:8080/#/c/8395/3/src/kudu/fs/error_manager.h@136 PS3, Line 136: // Runs the error notification callback. > Not necessary; ThreadPool is already fully thread safe. Done -- To view, visit http://gerrit.cloudera.org:8080/8395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie61c408a0b4424f933f40a31147568c2f906be0e Gerrit-Change-Number: 8395 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Wed, 01 Nov 2017 19:49:55 +0000 Gerrit-HasComments: Yes
