Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 )
Change subject: error_manager: synchronize/serialize handling ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager-test.cc File src/kudu/fs/error_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager-test.cc@20 PS4, Line 20: #include <string> > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager-test.cc@27 PS4, Line 27: #include "kudu/gutil/map-util.h" > warning: #includes are not sorted properly [llvm-include-order] Done http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager-test.cc@40 PS4, Line 40: using strings::Substitute; > warning: using decl 'Substitute' is unused [misc-unused-using-decls] Done http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h@80 PS4, Line 80: (err_handler) > This doesn't appear to actually invoke err_handler Not sure I fully understand, I thought () would invoke, even if it's not returning the resulting value? Anyway, I'm moving this to util/status.h. Usage is in {log,file}_block_manager.cc. http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h@96 PS4, Line 96: etesbefore > nit: space Done http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h@101 PS4, Line 101: class FsErrorManager { > Here's how I think about the Error Manager and how I think we should docume Sure, I'll put this in the commit message for now. http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h@126 PS4, Line 126: InsertOrUpdate(&cb_map_, e, std::move(cb)); > warning: passing result of std::move() as a const reference argument; no mo Done http://gerrit.cloudera.org:8080/#/c/8395/4/src/kudu/fs/error_manager.h@152 PS4, Line 152: std::map<ErrorHandlerType, ErrorNotificationCb> cb_map_; > Given that there are only two callback types, I don't think there's a need Done -- To view, visit http://gerrit.cloudera.org:8080/8395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie61c408a0b4424f933f40a31147568c2f906be0e Gerrit-Change-Number: 8395 Gerrit-PatchSet: 4 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Mon, 13 Nov 2017 22:48:50 +0000 Gerrit-HasComments: Yes
