Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 )
Change subject: error_manager: synchronize/serialize handling ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8395/5/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/8395/5/src/kudu/fs/error_manager.h@107 PS5, Line 107: // disk failure handling of the failed disks to return. > One thought on a potentially simpler approach: A previous rev had this implemented (see rev 3), but Adar convinced me that simplicity at the call-sites is perhaps more important. The main gripe was that it would be confusing to add such a Wait() call since developers in this layer of code would have to think something along the lines of "Could this indirectly fail due to some error that should be handled?" and if so, place in a Wait(). This approach, while adding slightly more complexity to the error manager, is simpler to use. If the block manager's gotten an error while doing something with a block (creating, writing to, etc.), it must be error-handled by one of the two callbacks. If a data dir UUID is available, call the disk-handling callback. Else, call the tablet-handling one. Also, considering the error manager could in the future be used for other kinds of errors (e.g. corruptions, space errors, etc), separate classes of error types seems not unreasonable. -- To view, visit http://gerrit.cloudera.org:8080/8395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie61c408a0b4424f933f40a31147568c2f906be0e Gerrit-Change-Number: 8395 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 14 Nov 2017 01:20:51 +0000 Gerrit-HasComments: Yes
