Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 )
Change subject: error_manager: synchronize/serialize handling ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8395/5/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/8395/5/src/kudu/fs/error_manager.h@107 PS5, Line 107: // disk failure handling of the failed disks to return. One thought on a potentially simpler approach: what if CreateNewBlock detected the case when all of the disks in the disk group are failed, and in that case, do something like the following before returning: foreach disk { wait for error callback to be complete on this disk } In the case that the disk error happened long ago, this "wait" would be instantaneous. In the case that the callbacks are still in progress, it would block until the error handling had finished? Then we don't need two separate types of callbacks? Or am I missing something about the issue at hand? -- To view, visit http://gerrit.cloudera.org:8080/8395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie61c408a0b4424f933f40a31147568c2f906be0e Gerrit-Change-Number: 8395 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 14 Nov 2017 01:11:05 +0000 Gerrit-HasComments: Yes
