Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/8395 )
Change subject: error_manager: synchronize/serialize handling ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/8395/5/src/kudu/fs/error_manager.h File src/kudu/fs/error_manager.h: http://gerrit.cloudera.org:8080/#/c/8395/5/src/kudu/fs/error_manager.h@107 PS5, Line 107: // disk failure handling of the failed disks to return. > The main gripe was that it would be confusing to add such a Wait() call since > developers in this layer of code would have to think something along the > lines of "Could this indirectly fail due to some error that should be > handled?" and if so, place in a Wait(). hmm.. isn't the only call site in my suggestion the 'CreateBlock' code where it determines there are no available disks? ie it doesn't have to change all the call sites in Tablet, etc, just the one place where we try to pick a disk to put a new block on? -- To view, visit http://gerrit.cloudera.org:8080/8395 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie61c408a0b4424f933f40a31147568c2f906be0e Gerrit-Change-Number: 8395 Gerrit-PatchSet: 5 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 14 Nov 2017 01:23:05 +0000 Gerrit-HasComments: Yes
