Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14760 )
Change subject: KUDU-2993: don't require update_dirs to fix directory inconsistencies ...................................................................... Patch Set 14: (7 comments) http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/block_manager_util.h File src/kudu/fs/block_manager_util.h: http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/block_manager_util.h@99 PS13, Line 99: PathInstanceMetadataPB* const metadata() const { return metadata_.get(); } > warning: return type 'const kudu::PathInstanceMetadataPB *const' is 'const' Done http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/data_dirs.h File src/kudu/fs/data_dirs.h: http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/data_dirs.h@237 PS13, Line 237: bool read_only; > warning: member variable 'read_only' has public visibility [misc-non-privat Ack http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/data_dirs.h@243 PS13, Line 243: UpdateInstanceBehavior update_instances; > warning: member variable 'update_instances' has public visibility [misc-non Ack http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/data_dirs.cc@504 PS13, Line 504: const set<string>& new_all_uuids) { > warning: the parameter 'instances_to_update' is copied for each invocation Done http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/data_dirs.cc@505 PS13, Line 505: unordered_map<string, string> copies_to_restore; > warning: the parameter 'new_all_uuids' is copied for each invocation but on Done http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/fs_manager.h File src/kudu/fs/fs_manager.h: http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/fs_manager.h@116 PS13, Line 116: bool read_only; > warning: member variable 'read_only' has public visibility [misc-non-privat Ack http://gerrit.cloudera.org:8080/#/c/14760/13/src/kudu/fs/fs_manager.h@122 PS13, Line 122: fs::UpdateInstanceBehavior update_instances; > warning: member variable 'update_instances' has public visibility [misc-non Ack -- To view, visit http://gerrit.cloudera.org:8080/14760 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic3027e7edb5c60e96ced6160fec1a380b38353a5 Gerrit-Change-Number: 14760 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: YangSong <[email protected]> Gerrit-Comment-Date: Thu, 05 Dec 2019 01:15:52 +0000 Gerrit-HasComments: Yes
